Support passwordless Pi-hole authentication and UI settings
All checks were successful
Test and publish Homegate / publish (push) Successful in 12m49s
Test and publish Homegate / checks (push) Successful in 29s

This commit is contained in:
2026-10-14 18:12:10 +03:00
parent a83d897b70
commit b305cc1ba8
13 changed files with 130 additions and 33 deletions

View File

@@ -31,8 +31,11 @@ class Transport:
self.fail_nginx = False
self.fail_dns = False
self.uploads = {}
self.pihole_session = {"valid": True, "sid": "TEST_SID", "csrf": "TEST_CSRF"}
self.requests = []
def send(self, session, request, **kwargs):
self.requests.append(request)
path = unquote(urlsplit(request.url).path.removeprefix("/api"))
method = request.method
data = json.loads(request.body) if request.body and "application/json" in request.headers.get("Content-Type", "") else None
@@ -43,7 +46,7 @@ class Transport:
body = {"token": "TEST_TOKEN"}
elif path == "/auth":
if method == "POST":
body = {"session": {"valid": True, "sid": "TEST_SID", "csrf": "TEST_CSRF"}}
body = {"session": self.pihole_session}
else:
status = 204
elif path.startswith("/nginx/"):
@@ -82,14 +85,14 @@ class Transport:
else:
raise AssertionError(path)
elif path == "/config/dns":
assert request.headers["X-FTL-SID"] == "TEST_SID"
assert request.headers.get("X-FTL-SID") == self.pihole_session["sid"]
if self.fail_dns:
status = 503
else:
body = {"config": {"dns": {"hosts": self.records, "cnameRecords": self.cnames}}}
elif path.startswith("/config/dns/hosts/"):
assert method == "PUT"
assert request.headers["X-FTL-SID"] == "TEST_SID"
assert request.headers.get("X-FTL-SID") == self.pihole_session["sid"]
entry = path.removeprefix("/config/dns/hosts/")
assert entry not in self.records
assert self.hosts[0]["meta"]["nginx_online"]
@@ -140,6 +143,35 @@ class HomegateTests(unittest.TestCase):
self.sync()
self.assertEqual([], self.transport.writes)
def test_passwordless_pihole_publishes_dns_without_auth_headers_or_logout(self):
self.transport.pihole_session = {"valid": True, "sid": None, "validity": -1,
"message": "no password set"}
self.transport.requests.clear()
self.dns.session.cookies.set("sid", "OLD_SESSION")
self.dns.login("")
self.sync()
self.assertIn("192.168.0.10 pve.home", self.transport.records)
self.assertIn("192.168.0.9 unrelated.home", self.transport.records)
self.transport.writes.clear()
self.sync()
self.dns.close()
self.assertEqual([], self.transport.writes)
for request in self.transport.requests:
if urlsplit(request.url).hostname == "pihole":
self.assertNotIn("X-FTL-SID", request.headers)
self.assertNotIn("X-FTL-CSRF", request.headers)
self.assertNotIn("Cookie", request.headers)
def test_invalid_pihole_session_does_not_enable_passwordless_access(self):
for session in ({"valid": False, "sid": None, "validity": -1},
{"valid": False, "sid": "invalid"}, {"valid": True},
{"valid": True, "sid": None, "validity": 300}):
with self.subTest(session=session), patch.object(self.dns, "call", return_value={"session": session}):
with self.assertRaisesRegex(h.Error, "Pi-hole authentication failed"):
self.dns.login("wrong-password")
self.assertNotIn("X-FTL-SID", self.dns.session.headers)
self.assertEqual([], self.transport.writes)
def test_renewal_uploads_and_reloads_existing_host(self):
self.sync()
old = self.transport.uploads[1]["certificate"]